Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

JTD timestamp option #1584

Merged
merged 6 commits into from
May 9, 2021
Merged

JTD timestamp option #1584

merged 6 commits into from
May 9, 2021

Conversation

jrr
Copy link
Contributor

@jrr jrr commented May 3, 2021 •
edited
Loading

What issue does this pull request resolve?

#1543

What changes did you make?

  • added timestamp configuration option, available only under JTD
  • added tests for its behavior
  • adjusted timestamp check accordingly

Is there anything that requires more attention while reviewing?

  • You might have a better idea of how to make different options available to the different flavors of AJV. (see the new AjvOptions type)
  • I didn't see a great place to test this in an existing suite (e.g. in the submodule JSON data) so I added a whole new test file.

@jrr jrr marked this pull request as ready for review May 4, 2021 02:13
@jrr jrr changed the title (draft) JTD timestamp option JTD timestamp option May 4, 2021
epoberezkin
epoberezkin reviewed May 4, 2021
View reviewed changes
lib/vocabularies/jtd/type.ts Outdated Show resolved Hide resolved
lib/2019.ts Outdated Show resolved Hide resolved
@epoberezkin
Copy link
Member

It's great - added some comments - thank you!

@epoberezkin
Copy link
Member

Thank you - will merge/release this week!

@epoberezkin epoberezkin merged commit df964e4 into ajv-validator:master May 9, 2021
@jrr jrr deleted the feature/jtd-date branch June 3, 2021 05:48
andriyl pushed a commit to Redocly/ajv that referenced this pull request Jun 16, 2021
@jrr @epoberezkin @andriyl
JTD timestamp option (ajv-validator#1584)
27cc202 
* add timestamp option for jtd

* tests for JTD timestamp option

* configurable timestamp check

* address feedback

* doc

Co-authored-by: Evgeny Poberezkin <2769109+epoberezkin@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@epoberezkin epoberezkin epoberezkin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrr @epoberezkin