fix: Update parseJson() for v8 11.7.72 and newer #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have verified this on https://regex101.com/, looks good. I will look to get this fix in after we get the builds working again. |
jasoniangreen
approved these changes
Feb 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
Fixes #2355
What changes did you make?
Update regex to extract end position from error in
parseJson()- the updated regex works both for the previous and the new v8 error messagesIs there anything that requires more attention while reviewing?
https://chromium-review.googlesource.com/c/v8/v8/+/3513684 also added some changes to the messages with some of the new message templates not mentioning a position at all. I'm not sure if this would affect ajv, but since
npm testcompletes successfully with my patch I assume it does not.