Fix punycode deprecation warning #2377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@epoberezkin CI appears to be broken in this repo overall. Can I help with that? |
…x/punycode-deprecation
|
@jasoniangreen any chance you could take a look? |
|
Hi @kibertoad sorry for the late reply. I have been speaking to @epoberezkin and he wants me to explore removing uri-js. It's not needed anymore for node given we are dropping older versions, but there is just an open question around browser support. I will update you when I have more. |
|
great news! thank you |
|
#2415, also have this PR |
|
I think if anything we'll go with #2415 or moving to a native approach so will close this. |
|
@jasoniangreen makes sense. what's preventing #2415 from being merged at this point? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2350 #2343
What issue does this pull request resolve?
punycode warnings. See linked issues.
What changes did you make?
Switched dependency to a fork that addresses the issue, and which is intended to be maintained for a long time.
Is there anything that requires more attention while reviewing?
No.