Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Chinese support got an issue #51

Open
hntee opened this issue Aug 24, 2020 · 1 comment
Open

Chinese support got an issue #51

hntee opened this issue Aug 24, 2020 · 1 comment
Labels
deficiency Something is not exactly fluent for somebody enhancement New feature or request

Comments

@hntee
Copy link

hntee commented Aug 24, 2020

Hi, I am new to up and encountered an issue while using it.
When the file is in Chinese, the characters are not displayed normally in the program

$ cat 1.txt
吃饭
喝茶
睡觉

Inside up, it showed only one character

cat 1.txt | up 
 |
吃
喝
睡

And grep cannot work well either.

@akavel akavel added deficiency Something is not exactly fluent for somebody enhancement New feature or request labels Nov 8, 2020
@akavel
Copy link
Owner

akavel commented Jan 15, 2021

#42 would probably fix this, but I have hard time getting myself to tweak/refactor it enough to make me confident it is correct, and also getting myself to add enough tests to also make me feel safe of that correctness 😞

akavel added a commit that referenced this issue Sep 4, 2024
Thanks @ujun. Fixes #51, at least so it looks.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
deficiency Something is not exactly fluent for somebody enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants