Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Start stop inclusive #150

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Start stop inclusive #150

merged 3 commits into from
Jun 21, 2022

Conversation

jvigliotta
Copy link
Collaborator

@jvigliotta jvigliotta commented Jun 16, 2022

Closes #147

Describe your changes:

To get around YAMCS excluding results with the same start/end when using order desc/asc (respectively), we will decrement the start time by 1ms when using order descending, and increment end time by 1ms when using ascending order.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@jvigliotta jvigliotta requested a review from akhenry June 16, 2022 22:50
@jvigliotta jvigliotta changed the base branch from master to release/2.0.5 June 16, 2022 22:51
@akhenry akhenry merged commit 5d7ab16 into release/2.0.5 Jun 21, 2022
@akhenry akhenry deleted the start-stop-inclusive branch June 21, 2022 17:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust parameter archive queries so that start and stop parameters are always inclusive.
2 participants