Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: Remove double 2.13 publish #1852

Merged
merged 1 commit into from
Oct 9, 2023
Merged

build: Remove double 2.13 publish #1852

merged 1 commit into from
Oct 9, 2023

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Oct 9, 2023

@@ -29,7 +29,7 @@ jobs:
- name: Publish
run: |-
sbt +publishSigned
CI_RELEASE=akka-grpc-codegen/publishSigned CI_SNAPSHOT_RELEASE=akka-grpc-codegen/publish sbt ++2.13.10\! publishSigned
CI_RELEASE=akka-grpc-codegen/publishSigned CI_SNAPSHOT_RELEASE=akka-grpc-codegen/publish
Copy link
Member Author

@patriknw patriknw Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the background of this, but could have been something with 2.12 and 2.13 cross publishing.
As far as I can see the above sbt +publishSigned will already publish for 2.13 and 3.

I don't know what that CI_RELEASE and CI_RELEASE is, but leaving that unchanged

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Raboof added that as a workaround for some publishing issues last year (#1400), not sure I understand why that is needed though.

@patriknw
Copy link
Member Author

patriknw commented Oct 9, 2023

let's try

@patriknw patriknw merged commit 9ce044e into main Oct 9, 2023
@patriknw patriknw deleted the wip-ci-patriknw branch October 9, 2023 09:35
johanandren pushed a commit that referenced this pull request Dec 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants