Provide access to akka-http request/response attributes #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes akka#859 This adds an `attribute`/`getAttribute` method to `Metadata`, and connects it to the underlying request/response that the metadata has been sourced from. I haven't implemented passing attributes on from user created metadata, I'm not sure if there's a use case for that.
jroper
force-pushed
the
request-attributes
branch
from
5db8204 to
63d7427
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #859
This adds an
attribute/getAttributemethod toMetadata, and connects it to the underlying request/response that the metadata has been sourced from.I haven't implemented passing attributes on from user created metadata, I'm not sure if there's a use case for that.