Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PERF] Akka: move all dispatchers off of the dedicated thread pool #7117

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[PERF] Akka: move all dispatchers off of the dedicated thread pool #7117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/core/Akka.Persistence/persistence.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,21 +77,21 @@ akka.persistence {
# Dispatcher used by every plugin which does not declare explicit
# `plugin-dispatcher` field.
default-plugin-dispatcher {
type = PinnedDispatcher
executor = "fork-join-executor"
type = Dispatcher
executor = "default-executor"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moves Akka.Persistence back over to the normal dispatcher when there isn't a custom one used by the plugin (there are none, IIRC)

}
# Default dispatcher for message replay.
default-replay-dispatcher {
type = ForkJoinDispatcher
executor = "fork-join-executor"
type = Dispatcher
executor = "default-executor"
dedicated-thread-pool {
# Fixed number of threads to have in this threadpool
thread-count = 8
}
}
# Default dispatcher for streaming snapshot IO
default-stream-dispatcher {
type = ForkJoinDispatcher
type = Dispatcher
dedicated-thread-pool {
# Fixed number of threads to have in this threadpool
thread-count = 8
Expand Down
4 changes: 2 additions & 2 deletions src/core/Akka.Remote/Configuration/Remote.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ akka {
### Default dispatcher for the remoting subsystem

default-remote-dispatcher {
executor = fork-join-executor
executor = default-executor
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moves Akka.Remote off of the dedicated thread pool

fork-join-executor {
parallelism-min = 2
parallelism-factor = 0.5
Expand All @@ -580,7 +580,7 @@ akka {
}

backoff-remote-dispatcher {
executor = fork-join-executor
executor = default-executor
fork-join-executor {
parallelism-min = 2
parallelism-max = 2
Expand Down
4 changes: 2 additions & 2 deletions src/core/Akka/Configuration/akka.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ akka {
# default dispatcher)
internal-dispatcher {
type = "Dispatcher"
executor = "fork-join-executor"
executor = "default-executor"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moves the internal dispatcher off its own dedicated thread pool

throughput = 5

fork-join-executor {
Expand All @@ -402,7 +402,7 @@ akka {

default-blocking-io-dispatcher {
type = "Dispatcher"
executor = "thread-pool-executor"
executor = "default-executor"
throughput = 1

# Akka.NET does not have a fine grained control over thread pool executor
Expand Down
Loading