Akka.Cluster.Tools: deprecate ClustersSingletonManagerSettings.ConsiderAppVersion #7302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jul 25, 2024
| if (settings.ConsiderAppVersion) | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| { | ||
| Log.Warning("As of Akka.NET v1.5.27, The 'ConsiderAppVersion' setting is no longer supported and will " + |
There was a problem hiding this comment.
Add a warning for users who had ConsiderAppVersion enabled - it was disabled by default, so it shouldn't affect too many people.
| @@ -188,7 +189,9 @@ private static string RoleOption(string role) | |||
| RemovalMargin = removalMargin; | |||
| HandOverRetryInterval = handOverRetryInterval; | |||
| LeaseSettings = leaseSettings; | |||
| #pragma warning disable CS0618 // Type or member is obsolete | |||
| ConsiderAppVersion = considerAppVersion; | |||
There was a problem hiding this comment.
Mark the setting as obsolete - it's already not getting used.
There was a problem hiding this comment.
The rest of the code changes in this file are fixing a few linger nullability issues and cleaning up TBD XML-DOC comments.
|
A remember-entities spec failed - I'll have to dig into that one later. |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cleanup from PR #7298
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
AppVersionjoins cluster #7197