Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

made ActorCell use nullable #7475

Merged
merged 8 commits into from
Jan 21, 2025
Merged

made ActorCell use nullable #7475

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d5a5388
cleaning up `ActorCell` and enabling nullability
Aaronontheweb Jan 20, 2025
ddb93c5
working on nullability for `ActorCell`
Aaronontheweb Jan 20, 2025
7fb6b6c
more nullability support
Aaronontheweb Jan 20, 2025
dabdca7
finished with nullability warnings
Aaronontheweb Jan 20, 2025
2fde95f
added API approvals
Aaronontheweb Jan 20, 2025
0e0d389
added real XML-DOC comment
Aaronontheweb Jan 20, 2025
fd0c1c1
Improve nullability implementation
Arkatufus Jan 21, 2025
ecad788
Update API Approval list
Arkatufus Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API approval file - you should still look over it but there's nothing super scary here. Going to comment on the changes in the source files themselves.

Original file line number Diff line number Diff line change
Expand Up @@ -59,35 +59,39 @@ namespace Akka.Actor
protected virtual void Unhandled(object message) { }
}
[System.Diagnostics.DebuggerDisplayAttribute("{Self,nq}")]
[System.Runtime.CompilerServices.NullableAttribute(0)]
public class ActorCell : Akka.Actor.IActorContext, Akka.Actor.IActorRefFactory, Akka.Actor.ICanWatch, Akka.Actor.ICell, Akka.Actor.IUntypedActorContext
{
public const int UndefinedUid = 0;
public ActorCell(Akka.Actor.Internal.ActorSystemImpl system, Akka.Actor.IInternalActorRef self, Akka.Actor.Props props, Akka.Dispatch.MessageDispatcher dispatcher, Akka.Actor.IInternalActorRef parent) { }
public Akka.Actor.Internal.IChildrenContainer ChildrenContainer { get; }
public int CurrentEnvelopeId { get; }
[System.Runtime.CompilerServices.NullableAttribute(2)]
public object CurrentMessage { get; }
public Akka.Dispatch.MessageDispatcher Dispatcher { get; }
public bool HasMessages { get; }
public bool IsLocal { get; }
protected bool IsNormal { get; }
public bool IsTerminated { get; }
protected bool IsTerminating { get; }
[System.Runtime.CompilerServices.NullableAttribute(2)]
public Akka.Dispatch.Mailbox Mailbox { get; }
public int NumberOfMessages { get; }
public Akka.Actor.IInternalActorRef Parent { get; }
public Akka.Actor.Props Props { get; }
public System.Nullable<System.TimeSpan> ReceiveTimeout { get; }
public Akka.Actor.IActorRef Self { get; }
[System.Runtime.CompilerServices.NullableAttribute(2)]
public Akka.Actor.IActorRef Sender { get; }
public Akka.Actor.ActorSystem System { get; }
public Akka.Actor.Internal.ActorSystemImpl SystemImpl { get; }
public virtual Akka.Dispatch.ActorTaskScheduler TaskScheduler { get; }
public virtual Akka.Actor.IActorRef ActorOf(Akka.Actor.Props props, string name = null) { }
public virtual Akka.Actor.IActorRef ActorOf(Akka.Actor.Props props, [System.Runtime.CompilerServices.NullableAttribute(2)] string name = null) { }
public Akka.Actor.ActorSelection ActorSelection(string path) { }
public Akka.Actor.ActorSelection ActorSelection(Akka.Actor.ActorPath path) { }
protected void AddWatcher(Akka.Actor.IActorRef watchee, Akka.Actor.IActorRef watcher) { }
protected void AddressTerminated(Akka.Actor.Address address) { }
public virtual Akka.Actor.IActorRef AttachChild(Akka.Actor.Props props, bool isSystemService, string name = null) { }
public virtual Akka.Actor.IActorRef AttachChild(Akka.Actor.Props props, bool isSystemService, [System.Runtime.CompilerServices.NullableAttribute(2)] string name = null) { }
protected virtual void AutoReceiveMessage(Akka.Actor.Envelope envelope) { }
public void Become(Akka.Actor.Receive receive) { }
public void BecomeStacked(Akka.Actor.Receive receive) { }
Expand All @@ -105,6 +109,7 @@ namespace Akka.Actor
public static Akka.Actor.IActorRef GetCurrentSenderOrNoSender() { }
public Akka.Actor.IInternalActorRef GetSingleChild(string name) { }
public void Init(bool sendSupervise, Akka.Dispatch.MailboxType mailboxType) { }
[return: System.Runtime.CompilerServices.NullableAttribute(2)]
public Akka.Actor.Internal.ChildRestartStats InitChild(Akka.Actor.IInternalActorRef actor) { }
public void Invoke(Akka.Actor.Envelope envelope) { }
protected virtual void PreStart() { }
Expand All @@ -113,14 +118,15 @@ namespace Akka.Actor
public void ReceiveMessageForTest(Akka.Actor.Envelope envelope) { }
protected void ReceivedTerminated(Akka.Actor.Terminated t) { }
protected void RemWatcher(Akka.Actor.IActorRef watchee, Akka.Actor.IActorRef watcher) { }
[return: System.Runtime.CompilerServices.NullableAttribute(2)]
protected Akka.Actor.Internal.SuspendReason RemoveChildAndGetStateChange(Akka.Actor.IActorRef child) { }
public void ReserveChild(string name) { }
public void Restart(System.Exception cause) { }
public void Resume(System.Exception causedByFailure) { }
public virtual void SendMessage(Akka.Actor.Envelope message) { }
public virtual void SendMessage(Akka.Actor.IActorRef sender, object message) { }
public virtual void SendSystemMessage(Akka.Dispatch.SysMsg.ISystemMessage systemMessage) { }
protected void SetActorFields(Akka.Actor.ActorBase actor) { }
protected static void SetActorFields(Akka.Actor.ActorBase actor) { }
protected bool SetChildrenTerminationReason(Akka.Actor.Internal.SuspendReason reason) { }
public void SetReceiveTimeout(System.Nullable<System.TimeSpan> timeout = null) { }
protected void SetTerminated() { }
Expand Down Expand Up @@ -2060,7 +2066,7 @@ namespace Akka.Actor.Internal
public virtual bool IsTerminating { get; }
public System.Collections.Generic.IReadOnlyCollection<Akka.Actor.Internal.ChildRestartStats> Stats { get; }
public abstract Akka.Actor.Internal.IChildrenContainer Add(string name, Akka.Actor.Internal.ChildRestartStats stats);
protected void ChildStatsAppender(System.Text.StringBuilder sb, System.Collections.Generic.KeyValuePair<string, Akka.Actor.Internal.IChildStats> kvp, int index) { }
protected static void ChildStatsAppender(System.Text.StringBuilder sb, System.Collections.Generic.KeyValuePair<string, Akka.Actor.Internal.IChildStats> kvp, int index) { }
public bool Contains(Akka.Actor.IActorRef actor) { }
public abstract Akka.Actor.Internal.IChildrenContainer Remove(Akka.Actor.IActorRef child);
public abstract Akka.Actor.Internal.IChildrenContainer Reserve(string name);
Expand Down Expand Up @@ -2118,6 +2124,7 @@ namespace Akka.Actor.Internal
{
public static Akka.Actor.Internal.InternalActivateFsmLogging Instance { get; }
}
[System.Runtime.CompilerServices.NullableAttribute(0)]
public class static InternalCurrentActorCellKeeper
{
public static Akka.Actor.ActorCell Current { get; set; }
Expand Down
15 changes: 11 additions & 4 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,35 +59,39 @@ namespace Akka.Actor
protected virtual void Unhandled(object message) { }
}
[System.Diagnostics.DebuggerDisplayAttribute("{Self,nq}")]
[System.Runtime.CompilerServices.NullableAttribute(0)]
public class ActorCell : Akka.Actor.IActorContext, Akka.Actor.IActorRefFactory, Akka.Actor.ICanWatch, Akka.Actor.ICell, Akka.Actor.IUntypedActorContext
{
public const int UndefinedUid = 0;
public ActorCell(Akka.Actor.Internal.ActorSystemImpl system, Akka.Actor.IInternalActorRef self, Akka.Actor.Props props, Akka.Dispatch.MessageDispatcher dispatcher, Akka.Actor.IInternalActorRef parent) { }
public Akka.Actor.Internal.IChildrenContainer ChildrenContainer { get; }
public int CurrentEnvelopeId { get; }
[System.Runtime.CompilerServices.NullableAttribute(2)]
public object CurrentMessage { get; }
public Akka.Dispatch.MessageDispatcher Dispatcher { get; }
public bool HasMessages { get; }
public bool IsLocal { get; }
protected bool IsNormal { get; }
public bool IsTerminated { get; }
protected bool IsTerminating { get; }
[System.Runtime.CompilerServices.NullableAttribute(2)]
public Akka.Dispatch.Mailbox Mailbox { get; }
public int NumberOfMessages { get; }
public Akka.Actor.IInternalActorRef Parent { get; }
public Akka.Actor.Props Props { get; }
public System.Nullable<System.TimeSpan> ReceiveTimeout { get; }
public Akka.Actor.IActorRef Self { get; }
[System.Runtime.CompilerServices.NullableAttribute(2)]
public Akka.Actor.IActorRef Sender { get; }
public Akka.Actor.ActorSystem System { get; }
public Akka.Actor.Internal.ActorSystemImpl SystemImpl { get; }
public virtual Akka.Dispatch.ActorTaskScheduler TaskScheduler { get; }
public virtual Akka.Actor.IActorRef ActorOf(Akka.Actor.Props props, string name = null) { }
public virtual Akka.Actor.IActorRef ActorOf(Akka.Actor.Props props, [System.Runtime.CompilerServices.NullableAttribute(2)] string name = null) { }
public Akka.Actor.ActorSelection ActorSelection(string path) { }
public Akka.Actor.ActorSelection ActorSelection(Akka.Actor.ActorPath path) { }
protected void AddWatcher(Akka.Actor.IActorRef watchee, Akka.Actor.IActorRef watcher) { }
protected void AddressTerminated(Akka.Actor.Address address) { }
public virtual Akka.Actor.IActorRef AttachChild(Akka.Actor.Props props, bool isSystemService, string name = null) { }
public virtual Akka.Actor.IActorRef AttachChild(Akka.Actor.Props props, bool isSystemService, [System.Runtime.CompilerServices.NullableAttribute(2)] string name = null) { }
protected virtual void AutoReceiveMessage(Akka.Actor.Envelope envelope) { }
public void Become(Akka.Actor.Receive receive) { }
public void BecomeStacked(Akka.Actor.Receive receive) { }
Expand All @@ -105,6 +109,7 @@ namespace Akka.Actor
public static Akka.Actor.IActorRef GetCurrentSenderOrNoSender() { }
public Akka.Actor.IInternalActorRef GetSingleChild(string name) { }
public void Init(bool sendSupervise, Akka.Dispatch.MailboxType mailboxType) { }
[return: System.Runtime.CompilerServices.NullableAttribute(2)]
public Akka.Actor.Internal.ChildRestartStats InitChild(Akka.Actor.IInternalActorRef actor) { }
public void Invoke(Akka.Actor.Envelope envelope) { }
protected virtual void PreStart() { }
Expand All @@ -113,14 +118,15 @@ namespace Akka.Actor
public void ReceiveMessageForTest(Akka.Actor.Envelope envelope) { }
protected void ReceivedTerminated(Akka.Actor.Terminated t) { }
protected void RemWatcher(Akka.Actor.IActorRef watchee, Akka.Actor.IActorRef watcher) { }
[return: System.Runtime.CompilerServices.NullableAttribute(2)]
protected Akka.Actor.Internal.SuspendReason RemoveChildAndGetStateChange(Akka.Actor.IActorRef child) { }
public void ReserveChild(string name) { }
public void Restart(System.Exception cause) { }
public void Resume(System.Exception causedByFailure) { }
public virtual void SendMessage(Akka.Actor.Envelope message) { }
public virtual void SendMessage(Akka.Actor.IActorRef sender, object message) { }
public virtual void SendSystemMessage(Akka.Dispatch.SysMsg.ISystemMessage systemMessage) { }
protected void SetActorFields(Akka.Actor.ActorBase actor) { }
protected static void SetActorFields(Akka.Actor.ActorBase actor) { }
protected bool SetChildrenTerminationReason(Akka.Actor.Internal.SuspendReason reason) { }
public void SetReceiveTimeout(System.Nullable<System.TimeSpan> timeout = null) { }
protected void SetTerminated() { }
Expand Down Expand Up @@ -2058,7 +2064,7 @@ namespace Akka.Actor.Internal
public virtual bool IsTerminating { get; }
public System.Collections.Generic.IReadOnlyCollection<Akka.Actor.Internal.ChildRestartStats> Stats { get; }
public abstract Akka.Actor.Internal.IChildrenContainer Add(string name, Akka.Actor.Internal.ChildRestartStats stats);
protected void ChildStatsAppender(System.Text.StringBuilder sb, System.Collections.Generic.KeyValuePair<string, Akka.Actor.Internal.IChildStats> kvp, int index) { }
protected static void ChildStatsAppender(System.Text.StringBuilder sb, System.Collections.Generic.KeyValuePair<string, Akka.Actor.Internal.IChildStats> kvp, int index) { }
public bool Contains(Akka.Actor.IActorRef actor) { }
public abstract Akka.Actor.Internal.IChildrenContainer Remove(Akka.Actor.IActorRef child);
public abstract Akka.Actor.Internal.IChildrenContainer Reserve(string name);
Expand Down Expand Up @@ -2116,6 +2122,7 @@ namespace Akka.Actor.Internal
{
public static Akka.Actor.Internal.InternalActivateFsmLogging Instance { get; }
}
[System.Runtime.CompilerServices.NullableAttribute(0)]
public class static InternalCurrentActorCellKeeper
{
public static Akka.Actor.ActorCell Current { get; set; }
Expand Down
Loading
Loading