Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(backport release-1.2): fix: fix faulty logic for handling possible double-encoding of github app private key #3379

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

akuitybot
Copy link

Automated backport to release-1.2, triggered by a label in #3363.

… app private key (#3363)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
(cherry picked from commit f28ce2f)
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit c8e764a
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6797eabcad042300084fe157
😎 Deploy Preview https://deploy-preview-3379.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour added this to the v1.2.2 milestone Jan 27, 2025
@krancour krancour enabled auto-merge (squash) January 27, 2025 20:21
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (cf51d11) to head (c8e764a).
Report is 1 commits behind head on release-1.2.

Files with missing lines Patch % Lines
internal/credentials/kubernetes/github/app.go 68.75% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.2    #3379      +/-   ##
===============================================
+ Coverage        52.48%   52.50%   +0.01%     
===============================================
  Files              291      291              
  Lines            26613    26625      +12     
===============================================
+ Hits             13968    13979      +11     
  Misses           11882    11882              
- Partials           763      764       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour merged commit 2c3048d into release-1.2 Jan 27, 2025
23 checks passed
@krancour krancour deleted the backport-3363-to-release-1.2 branch January 27, 2025 20:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants