[BUG] Code sections isn't working for Javascript language

[TaylorHo]

I tested with Java, Dart, and Javascript. Javascript was the only one of those languages where the sections didn't work.

I was trying to make the code read-only with controller.readOnlySectionNames = {'section1'};.

Dart example:

final controller = CodeController(
    text: '''
          // [START section1]
          final String test = "testing here";
          // [END section1]
          ''',
    language: dart,
    namedSectionParser: const BracketsStartEndNamedSectionParser(),
  );

Result:

---

Javascript example:

final controller = CodeController(
    text: '''
          // [START section1]
          console.log("teste");
          // [END section1]
          ''',
    language: javascript,
    namedSectionParser: const BracketsStartEndNamedSectionParser(),
  );

Result:

[ron-diesel]

I have the same issue

[UbayGD]

I encountered the same problem today with “typescript”.

I'm doing some “research” and modifying the test code_controller_readonly_sections_test.dart to make the ‘Initial, changing’ case use TypeScript instead of Java, fails (obviously I've changed the entire snippet so that the ‘full’ property is a valid TypeScript class).

class TwoMethodsTypescriptSnippet {
  static Mode get mode => typescript;

  static const full = '''
class MyClass {
  method1() {
    if (false) {// [START section1]
      return;
    }// [END section1]
  }

  method2() {// [START section2]
    return;
  }// [END section2]
}
''';
}

controller.code.lines.lines[2].text = "    if (false) {// [START section1]"

controller.code.lines.lines[2].isReadOnly = false

Maybe the problem is a BracketsStartEndNamedSectionParser thing. I'll take a look at it

[UbayGD]

With the test code_read_only_test the same thing happens, when indicating that the language is TypeScript the test fails and the result indicates that none of the lines is “readonly”.

[UbayGD]

This issue should be solved by now, after the PR was merged