[#3173]Update field names in all entries. #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muloem
reviewed
Sep 24, 2019
| @@ -72,7 +72,7 @@ private void processAssignments(DatastoreService ds) { | |||
| for (Entity ass : pq.asIterable(FetchOptions.Builder.withChunkSize(500))) { | |||
|
|
|||
| boolean splitAllowed = true; | |||
| boolean forceSplit = false; | |||
| boolean forceSplit = true; //want to write the surveyId and new field names to all | |||
There was a problem hiding this comment.
If its always going to be true then do we even need to have the variable?
There was a problem hiding this comment.
It's more like a constant now :) Strictly no, I just thought it made the logic clearer.
muloem
approved these changes
Sep 27, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the PR (what is the issue or what needed to be done)
Need to update the field names as used by #3166.
The solution
Screenshots (if appropriate)
Checklist