Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enumerators cannot see results page for private projects #3457

Closed
punchagan opened this issue Jan 16, 2019 · 0 comments
Closed

Enumerators cannot see results page for private projects #3457

punchagan opened this issue Jan 16, 2019 · 0 comments
Assignees
@punchagan
Labels
Bug
Milestone
Hot-fix 3.40.6 M...

Comments

@punchagan
Copy link
Contributor

No description provided.

@punchagan punchagan added the Bug label Jan 16, 2019
@punchagan punchagan self-assigned this Jan 16, 2019
punchagan added a commit that referenced this issue Jan 16, 2019
@punchagan
[#3457] Let enumerators view private projects' results framework
9c47813 
Enumerators had change permissions on indicator period data (updates), but did
not have view permissions on the indicator periods, indicators or results that
are needed to populate this framework.

This commit adds a view_ permission on these hierarchical objects for the
enumerator. Everyone who has a `change` permission is assumed to have `view`
permissions already.

This commit also changes the code used to filter out objects in a queryset for
logged in users who are not admins. Previously, the objects were filtered based
on whether the user has `change` permissions on an object. This has now been
changed to check for `view` permission if the request is a `GET` and otherwise
check for the `change` permission.

Closes #3457
@punchagan punchagan mentioned this issue Jan 16, 2019
Merged
5 tasks
@ghost ghost added the Needs Review label Jan 16, 2019
zzgvh added a commit that referenced this issue Jan 16, 2019
@zzgvh
Merge pull request #3458 from akvo/issue/3457-private-projects-enumer…
c9f1ec4 
…ator-permissions

[#3457] Let enumerators view private projects' results framework
Code rewiewed!
@ghost ghost removed the Needs Review label Jan 16, 2019
@punchagan punchagan added this to the Hot-fix 3.40.6 Managua milestone Jan 16, 2019
@MichaelAkvo MichaelAkvo added this to RSR Dec 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@punchagan punchagan

Labels
Bug
Projects
RSR
Archived in project
Milestone
Hot-fix 3.40.6 Managua
Development

No branches or pull requests
1 participant
@punchagan