Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

project.last_modified_at needs to be updated from every endpoint #3742

Closed
martinchristov opened this issue Aug 14, 2019 · 0 comments
Closed

project.last_modified_at needs to be updated from every endpoint #3742

martinchristov opened this issue Aug 14, 2019 · 0 comments
Assignees
@punchagan
Labels
Bug
Milestone
Hot-fix 4.0.2 Ma...

Comments

@martinchristov
Copy link
Contributor

Currently the "Updated at [time]" info we display in the upper left corner of the project editor is wrong in some cases. For example if you open a project you last edited yesterday it will show "Updated yesterday by Martin". If you then go to section5 (or any section), change something it will say "Updated just now". Then, however if you refresh the page it will say "Updated yesterday".
This is due to the "last_updated_at" field of the /project/ not being updated.
punchagan added a commit that referenced this issue Sep 18, 2019
@punchagan
[#3742] Add LogEntry for all CRUD operations from the API
fbf3f6e 
This commit adds logging in the Django `LogEntry` table for all API calls to
viewsets that are subclassing the `PublicProjectViewSet`. If the API call
updates an object other than a `Project`, two log entries are created - one
for the actual object that changed, and another for the project to which
this object is related to.

The function to log these changes is a cleaner version of the `log_changes`
function that was being used in the old Project Editor. The entry format has
been changed from the previous logging function to match the Django logging
format more closely.
punchagan added a commit that referenced this issue Sep 18, 2019
@punchagan
[#3742] Change ProjectSerializer.last_modified_at field
bc37080 
Project.last_modified_at is updated internally by Django, when a save is
called on the project. `Project.last_modified_by` is a property that uses
entries in the `LogEntry` table to get last modified time and user
information. The `ProjectSerializer` has been updated in this commit to use
this property on the Project for the `last_modified_at` field.

Closes #3742
punchagan added a commit that referenced this issue Sep 18, 2019
@punchagan
[#3742] Add LogEntry for all CRUD operations from the API
afabe84 
This commit adds logging in the Django `LogEntry` table for all API calls to
viewsets that are subclassing the `PublicProjectViewSet`. If the API call
updates an object other than a `Project`, two log entries are created - one
for the actual object that changed, and another for the project to which
this object is related to.

The function to log these changes is a cleaner version of the `log_changes`
function that was being used in the old Project Editor. The entry format has
been changed from the previous logging function to match the Django logging
format more closely.
punchagan added a commit that referenced this issue Sep 18, 2019
@punchagan
[#3742] Change ProjectSerializer.last_modified_at field
411a184 
Project.last_modified_at is updated internally by Django, when a save is
called on the project. `Project.last_modified_by` is a property that uses
entries in the `LogEntry` table to get last modified time and user
information. The `ProjectSerializer` has been updated in this commit to use
this property on the Project for the `last_modified_at` field.

Closes #3742
punchagan added a commit that referenced this issue Sep 18, 2019
@punchagan
[#3742] Add LogEntry for all CRUD operations from the API
0dd0c78 
This commit adds logging in the Django `LogEntry` table for all API calls to
viewsets that are subclassing the `PublicProjectViewSet`. If the API call
updates an object other than a `Project`, two log entries are created - one
for the actual object that changed, and another for the project to which
this object is related to.

The function to log these changes is a cleaner version of the `log_changes`
function that was being used in the old Project Editor. The entry format has
been changed from the previous logging function to match the Django logging
format more closely.
punchagan added a commit that referenced this issue Sep 18, 2019
@punchagan
[#3742] Change ProjectSerializer.last_modified_at field
d4fe265 
Project.last_modified_at is updated internally by Django, when a save is
called on the project. `Project.last_modified_by` is a property that uses
entries in the `LogEntry` table to get last modified time and user
information. The `ProjectSerializer` has been updated in this commit to use
this property on the Project for the `last_modified_at` field.

Closes #3742
punchagan added a commit that referenced this issue Sep 19, 2019
@punchagan
[#3742] Add LogEntry for all CRUD operations from the API
8291847 
This commit adds logging in the Django `LogEntry` table for all API calls to
viewsets that are subclassing the `PublicProjectViewSet`. If the API call
updates an object other than a `Project`, two log entries are created - one
for the actual object that changed, and another for the project to which
this object is related to.

The function to log these changes is a cleaner version of the `log_changes`
function that was being used in the old Project Editor. The entry format has
been changed from the previous logging function to match the Django logging
format more closely.
punchagan added a commit that referenced this issue Sep 19, 2019
@punchagan
[#3742] Remove specific logging for dimension value and name
d8ad3a1
@zuhdil zuhdil closed this as completed in 04e3d82 Sep 19, 2019
@punchagan punchagan added the Bug label Sep 19, 2019
@punchagan punchagan self-assigned this Sep 19, 2019
punchagan added a commit that referenced this issue Sep 27, 2019
@punchagan
[#3742] Fix flaky test when logging project changes
9a6f12c
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 7, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@punchagan punchagan

Labels
Bug
Projects
RSR
Archived in project
Milestone
Hot-fix 4.0.2 Malachite Kingfisher
Development

No branches or pull requests
2 participants
@punchagan @martinchristov