[#4725] quickfix: cache entire project directory request #4726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelAkvo
force-pushed
the
feature/4725-/rest/v1/project_directory-performance
branch
from
82e63ce to
ef6b81e
Compare
|
It takes ~7m to cache all projects. It then takes ~10-20 seconds for the first request and < 1 second for cached requests. About half the time is spent rendering the response and on a slow network more time is spent transferring the response. |
The projects don't change often, so we should be able to cache them for a while. Additionally, every hour we will regenerate their cached values (take ~7m right now). So the quick fix is two-fold: - cache the entire result and keep for an hour - regenerate per project cache every hour Once the page cache expires, queries should take ~10-20 seconds, but only once until the next hour. #4725: /rest/v1/project_directory performance
MichaelAkvo
force-pushed
the
feature/4725-/rest/v1/project_directory-performance
branch
from
ef6b81e to
6a315de
Compare
For some reason it takes a whole lot of time to reverse an URL. Even the example for `cached_property` uses `absolute_url` as an example. #4725: /rest/v1/project_directory performance
MichaelAkvo
changed the title
MichaelAkvo
changed the title
MichaelAkvo
force-pushed
the
feature/4725-/rest/v1/project_directory-performance
branch
from
132cc92 to
7221ff4
Compare
Instead of relying on django to make deferred queries, we make all queries ourselves, build the cache, and use it. It's per project ID for faster access. Additionally, `url` is not required anymore as the UI builds the url to the project now #4725: /rest/v1/project_directory performance
MichaelAkvo
force-pushed
the
feature/4725-/rest/v1/project_directory-performance
branch
from
7221ff4 to
9b0f6a3
Compare
MichaelAkvo
deleted the
feature/4725-/rest/v1/project_directory-performance
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The projects don't change often, so we should be able to cache them for a while.
Additionally, every hour we will regenerate their cached values (take ~7m right now).
So the quick fix is two-fold:
Once the page cache expires, queries should take ~10-20 seconds, but only once until the next hour.
Related to #4725: /rest/v1/project_directory performance