Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feature/1096 add forms entity validation #1104

Merged
merged 18 commits into from
Feb 2, 2024
Merged

Feature/1096 add forms entity validation #1104

merged 18 commits into from
Feb 2, 2024

Conversation

ifirmawan
Copy link
Contributor

@ifirmawan ifirmawan commented Jan 31, 2024 •
edited
Loading

TODO/DONE

  • Backend handle forms entity validation
  • Frontend implements forms entity validation
  • Backend update tests

@ifirmawan
[#1096] Add related_name entity_data to access it via Entity model
0dffec0
@ifirmawan
[#1096] Add Forms Entity Validation from BE
af51378 
Implements forms entity validation with custom queryset in PrimaryKeyRelatedField serializers.
Workflow:
- Get selected forms
- Get selected administrations
- Filter selected forms that have entity cascade questions
- if entity cascade questions exists then
-- Check existing entity types
--- if entity doesnt exists then show validation error message
--- if entity exists then
---- Filter entity_data by entity type and selected administrations
---- if filtered entity_data doesnt exists then show validation error message that containing form & entity type
- otherwise validation passed and response HTTP Status 201
@ifirmawan
Merge branch 'develop' into feature/1096-add-forms-entity-validation
71490fe
@ifirmawan ifirmawan self-assigned this Jan 31, 2024
@coveralls
Copy link

Coverage Status

coverage: 80.718% (-0.2%) from 80.894%
when pulling c03e029 on feature/1096-add-forms-entity-validation
into 858d738 on develop.

@ifirmawan ifirmawan marked this pull request as ready for review January 31, 2024 10:19
@ifirmawan ifirmawan linked an issue Jan 31, 2024 that may be closed by this pull request
Add Forms Entity Validation #1096
Closed
@dedenbangkit dedenbangkit merged commit ac88088 into develop Feb 2, 2024
2 checks passed
@dedenbangkit dedenbangkit deleted the feature/1096-add-forms-entity-validation branch February 2, 2024 03:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dedenbangkit dedenbangkit dedenbangkit approved these changes

Assignees

@ifirmawan ifirmawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Forms Entity Validation
3 participants
@ifirmawan @coveralls @dedenbangkit