1582 Fix experts invitations related permissions handling #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Re #1582] Fixed query to get experts results needed to be able to detect an expert user needs to be converted to an approved user. Besides, we have instrumented the code of update stakeholder-related function to unassign unapproved user role from the expert user in case it is detected as such, and be able to assign the approved user role in that case as well. The added functions have their rollbacks as well and we have also added one for the update stakeholder's final function, to have a consistent behaviour. On the other hand the endpoint to accept invitations looks not to be in use and such this looks like the only entrypoint to fix, but we will check. Now we are also catching better the exceptions, using Throwable class.
joseAyudarte91
deleted the
1582-fix-expert-invitations-permissions-handling
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Re #1582]
Fixed query to get experts results needed to be able to detect an expert user needs to be converted to an approved user.
Besides, we have instrumented the code of update stakeholder-related function to unassign unapproved user role from the expert user in case it is detected as such, and be able to assign the approved user role in that case as well. The added functions have their rollbacks as well and we have also added one for the update stakeholder's final function, to have a consistent behaviour.
On the other hand the endpoint to accept invitations looks not to be in use and such this looks like the only entrypoint to fix, but we will check.
Now we are also catching better the exceptions, using Throwable class.
This issue is related to #1530 and #1543 refactors.