Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

release resources on shutdown #57

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

al8n
Copy link
Owner

@al8n al8n commented Dec 23, 2024

No description provided.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 64.44444% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.93%. Comparing base (fa5f93f) to head (b0ee463).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
transports/net/src/lib.rs 68.75% 10 Missing ⚠️
transports/net/src/io/send_by_packet.rs 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   73.00%   72.93%   -0.07%     
==========================================
  Files          64       64              
  Lines        6756     6781      +25     
==========================================
+ Hits         4932     4946      +14     
- Misses       1824     1835      +11     
Files with missing lines Coverage Δ
transports/net/src/io/send_by_packet.rs 83.96% <53.84%> (-1.30%) ⬇️
transports/net/src/lib.rs 74.18% <68.75%> (-0.73%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5f93f...b0ee463. Read the comment docs.

@al8n al8n merged commit 1e580a7 into main Dec 23, 2024
37 of 40 checks passed
@al8n al8n deleted the net/release-resources-on-shutdown branch December 23, 2024 15:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant