Add support for vector-effect property #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only "non-scaling-stroke" and "none" are supported
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to address the issue noted in #113.
Not being familiar with the SVG-to-PDFKit codebase, it's possible that I've missed cases where this fails; it does seem to work for the example file here:
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/vector-effect#example_vector-effectnon-scaling-stroke
Only "non-scaling-stroke" and "none" are supported options; according to https://caniuse.com/vector-effect , the other properties are generally unsupported and at risk of being deprecated.