fix of svg pattern filling on pdfkit/pdfmake at minified version #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the problem
The svg pattern filling isn't correctly draw when a pdf is created at production. The problem seems to be related to the if statement on
docFillColoranddocFillColorfunctions. The color parameter, when in production, has a different strutucture. The problem is reported at pdfMake/issue#1832before
the conditional statement on
docFillColoranddocFillColorfunctions is currently likeif (color[0].constructor.name === 'PDFPattern')after
i`ve added another condition to both if statements
if (color[0].constructor.name === 'PDFPattern' || color[0].dx)