-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[WIP] Notebook - general-exploration-landcover_io #110
Conversation
✅ Deploy Preview for the-environmental-ds-book ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@jamesdamillington the proof of the notebook is ready for your revision. Please feel free it the Netlify preview box above or click here. To reduce the length of the notebook, all cells with static/interactive plots and others with considerable code have the Click to show button. Note this only hides cells in the html version and not when you open the file in Binder or locally. Please confirm and provide comments where necessary:
(optional) @annefou @aedebus can you confirm if you have any comments of the proof? |
@acocac Thanks for all your work pulling the proof together! It all looks good to me except for one thing: in Section 3 the Tip box says
But the code was not commented and so the interactive plot does show in the notebook... We should either remove the Tip box (preferable I think) or comment the code out and re-compile so the Everything else looks okay (Binder takes a long time to boot but once it has, everything seems to work okay) |
@jamesdamillington thanks for the quick reply! |
@jamesdamillington can you double check the preview? it should have the suggested change in the tip box. May I ask if you can complete the checkbox of my previous comment. This is a sort of final confirmation that the notebook is ok to go (: |
Hi @acocac Thanks for the edit. Everything looks great and good to go, but how do I check the boxes? |
Cool - Thanks for confirming all looks good to you! Regarding the checking boxes, you can copy them into a new comment and check them in case you cannont click-on each of them at my comment. |
|
Excellent.
Cool - thanks for confirming all is ok. Apart from the nice and well-documented sections of the notebook, I've learnt how to properly cross-reference them which would be a very useful tip to recommend in the WIP PR#115 on improved guidelines. I hope the publication process has been a positive experience for you and reviewers! |
Before review
Description
Add the executable notebook Exploring Land Cover Data (Impact Observatory) (see the notebook idea in issue #99).
Motivation and Context
New notebook contribution to the exploration theme.
How has this been tested?
GitHub actions deployed the forked template by the main author, @jamesdamillington, then the repo was transferred to the EnvDS book organisation (see https://github.com/Environmental-DS-Book/general-exploration-landcover_io).
Types of changes
Checklist:
Additional information