Fix infinite loop on incomplete JSX (#296)

Fixes #294
alangpierce · Jul 6, 2018 · 9b75b41 · 9b75b41
1 parent 71d74c4
commit 9b75b41
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/parser/plugins/jsx/index.ts b/src/parser/plugins/jsx/index.ts
@@ -73,6 +73,9 @@ function jsxReadString(quote: number): void {
 function jsxReadWord(): void {
   let ch: number;
   do {
+    if (state.pos > input.length) {
+      unexpected(null, "Unexpectedly reached the end of input.");
+    }
     ch = input.charCodeAt(++state.pos);
   } while (isIdentifierChar(ch) || ch === charCodes.dash);
   finishToken(tt.jsxName);

diff --git a/test/jsx-test.ts b/test/jsx-test.ts
@@ -1,4 +1,6 @@
-import {Transform} from "../src";
+import {throws} from "assert";
+
+import {transform, Transform} from "../src";
 import {IMPORT_DEFAULT_PREFIX, JSX_PREFIX} from "./prefixes";
 import * as util from "./util";
 
@@ -466,6 +468,10 @@ describe("transform JSX", () => {
     );
   });
 
+  it("does not infinite loop on incomplete JSX", () => {
+    throws(() => transform("const x = <", {transforms: ["jsx"]}));
+  });
+
   describe("with production true", () => {
     it("handles no props", () => {
       assertResult(