Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

React displayName does not work with MemberExpression LHS #253

Closed
arv opened this issue Jun 16, 2018 · 1 comment · Fixed by #274
Closed

React displayName does not work with MemberExpression LHS #253

arv opened this issue Jun 16, 2018 · 1 comment · Fixed by #274
Assignees
@alangpierce

Comments

@arv
Copy link
Contributor

arv commented Jun 16, 2018

displayName works with variable assignment and AssignmentExpression when the LHS is an identifier expression but not when the LHS is a MemberExpression.

https://sucrase.io/#selectedTransforms=jsx,imports&code=%0Aa.b.c%20%3D%20React.createClass(%7B%0A%20%20render()%20%7B%0A%20%20%20%20return%20%3Ca%2F%3E%0A%20%20%7D%0A%7D)
@alangpierce alangpierce self-assigned this Jun 25, 2018
alangpierce added a commit that referenced this issue Jun 25, 2018
@alangpierce
Allow member expression identifiers when determining React displayName
3e2923e 
Fixes #253

Also fix stale comment.
@alangpierce alangpierce mentioned this issue Jun 25, 2018
Merged
alangpierce added a commit that referenced this issue Jun 25, 2018
@alangpierce
Allow member expression identifiers when determining React displayName (
40af8e5 
#274)

Fixes #253

Also fix stale comment.
@arv
Copy link
Contributor Author

arv commented Jun 25, 2018

Thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@alangpierce alangpierce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow member expression identifiers when determining React displayName alangpierce/sucrase
2 participants
@arv @alangpierce