Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expand copyright to include babylon/acorn authors, add AUTHORS file #219

Merged
merged 1 commit into from
May 29, 2018

Conversation

alangpierce
Copy link
Owner

No description provided.

@alangpierce
Copy link
Owner Author

@kittens does this seem like a reasonable way to do it? The copyright is a bit complex I guess, and it's a little weird in that Acorn explicitly lists all contributors and Babel seems to be completely under your name and doesn't track contributors as far as I can tell. Fortunately it's all the same license.

@alangpierce alangpierce merged commit f31d01f into master May 29, 2018
@sebmck
Copy link

sebmck commented May 29, 2018

You just need to put the LICENSE and AUTHORS file into the sucrase-babylon folder and you're fine.

@alangpierce
Copy link
Owner Author

Ah, I see. I was planning on integrating it into the rest of the code pretty soon anyway; it's just tech debt that it's still its own top-level folder, rather than any significant attempt at keeping it a coherent fork or independent module. Does the top-level license approach make sense to you given that interpretation? Happy to add LICENSE and AUTHORS in the subdirectory regardless if you think that's better.

@alangpierce alangpierce deleted the add-authors-file branch June 30, 2018 21:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants