Fix crash on destructured params in arrow function types #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #277 There's a decision point on whether the upcoming type is a function type or not, and it wasn't considering destructured params.
alangpierce
added a commit
that referenced
this pull request
Mar 31, 2019
Progress toward #437 Notes about each change: 4e1d6e7ff v7.1.6 🚫 Release only. a2afb974b Fix parsing typescript function types with destructuring (#9035) 🚫 Already fixed with #278. 445b14148 Better error for disallowed trailing commas/parameters after rest elements (#9046) 🚫 Just error reporting. e7f0c065c Bump some deps (#9056) 🚫 Nothing to do. 4f16a12c0 Fix bug with parsing TS generic async arrow function (#9055) 🚫 Sucrase seems unaffected by bug. d2971a195 Fix compatibility between typescript and jsx plugins in interface declarations (#9058) 🚫 Sucrase seems unaffected by bug. 856edbf95 [flow] Allow type casts in array patterns inside arrow parameters (#9069) 🚫 Bug caused by error reporting, doesn't affect Sucrase. 61f2aed5b Disallow await inside arrow functions (#9074) 🚫 Error handling out of scope for Sucrase. 07eaa3c63 Ignore empty fixture directories and fix fixtures in the parser (#9113) 🚫 Test-only. 393283053 Parse non-octals with leading zeros in non strict mode correctly (#9114) 🚫 Sucrase assumes strict mode, so this doesn't apply. fa9df678a Move tests from babylon to babel-parser and enable one test that works now 🚫 Test-only. fdc869ce1 Merge pull request #8289 from valtech-nyc/implement-smart-pipeline-in-parser ✅ Almost all logic was for error-reporting and complexity around node creation, but I did add # as a valid expression. 282129ea6 v7.2.0 🚫 Release only. 4ca35ef8b Fix running flow on travis and update flow (#9128) 🚫 Types only. 72471aff6 Handle flow comments with leading spaces (#9168) 🚫 Sucrase doesn't do anything special for flow comments. c1499b13a v7.2.2 🚫 Release only. 5cb38995c Allow keywords to be used in type annotations (#9184) ✅ I also fixed this for TypeScript. 0bb720401 v7.2.3 🚫 Release only. b5177ce29 babel-parser: typescript: add missing bigint keyword (#9230) 🚫 Test only. 60ffe1d10 parser, smart pipes: Add test for async–await 🚫 Test only. c586d4e8c parser, smart pipes: Add support for yield in pipeline bodies 🚫 Only validation change, startsExpr was removed from Sucrase. a58893d1e Ensure modifiers are included in TSParameterProperty ranges (#9276) 🚫 AST only. e43777bb5 Fix location for typescript type assertions in AST (#9284) 🚫 AST only, wasn't a problem in Sucrase tokens. 03022d169 Throw error if TypeScript class has empty implements (#9292) 🚫 Error handling only. 46e3f6df1 @babel/parser: include leading character into range of generic ArrowFunctionExpression (#9295) 🚫 AST only. 2cc037675 @babel/parser(ts): Add parsing of type import (#9302) 🚫 Already done in #380. 9764718c3 Disallow trailing comma after rest (#9311) 🚫 Error handling only. 5889620a6 Disallow `new import(x)` and `import(x,)` (#9313) 🚫 Error handling only. 3e4b608a8 Parse class heritage as strict mode code (#9315) 🚫 Sucrase is always in strict mode. 694e3fd8c Merge declaration and init of props in parser's state (#9312) 🚫 Refactor that isn't relevant to Sucrase. e8038863c Fix range on TypeScript this type predicate (#9339) 🚫 AST only. 34c9890f4 Fix range on TypeScript index signature parameters (#9335) 🚫 AST only. aaec2cd51 Fix handling newline with TypeScript declare and abstract classes (#9328) ✅ Implemented newline checking in various places. 0a88230ec Disallow async functions as loop bodies (#9314) 🚫 Error handling only. a2e6d8e96 Disallow usage of invalid keyword after export abstract statement in Typescript (#9336) 🚫 Error handling only. 96a734314 Merge pull request #9348 from danez/perf 🚫 Nothing stood out as being valuable to incorporate. f6ee26c3d v7.3.0 🚫 Release only. af88e63df fix new keyword broken by recent refactoring (#9377) 🚫 Not relevant in Sucrase. f2af6c117 v7.3.1 🚫 Release only. f77c450cd Bump prettier (#9373) 🚫 Tooling only. 65febdd13 Refactor import and export parsing (#9326) 🚫 Skipping refactor for now since it's not clear that I'll need it. 93e1b5e61 Merge pull request #9375 from danez/contextual-let 🚫 Not necessary for strict mode. 8bc9f9a05 fix: Allow toplevel await when option true and correctly mark await keyword as unexpected (#9371) 🚫 Error handling only. 42c5d3fc4 Correctly fail for invalid yield in for (#9398) 🚫 Error handling only. 46ba5940c Make yield a contextual keyword (#9400) 🚫 Not necessary for strict mode. 7dc157f9b Fix location/range on TypeScript ExportNamedDeclarations (#9406) 🚫 AST only.
alangpierce
added a commit
that referenced
this pull request
Mar 31, 2019
Progress toward #437 Notes about each change: 4e1d6e7ff v7.1.6 🚫 Release only. a2afb974b Fix parsing typescript function types with destructuring (#9035) 🚫 Already fixed with #278. 445b14148 Better error for disallowed trailing commas/parameters after rest elements (#9046) 🚫 Just error reporting. e7f0c065c Bump some deps (#9056) 🚫 Nothing to do. 4f16a12c0 Fix bug with parsing TS generic async arrow function (#9055) 🚫 Sucrase seems unaffected by bug. d2971a195 Fix compatibility between typescript and jsx plugins in interface declarations (#9058) 🚫 Sucrase seems unaffected by bug. 856edbf95 [flow] Allow type casts in array patterns inside arrow parameters (#9069) 🚫 Bug caused by error reporting, doesn't affect Sucrase. 61f2aed5b Disallow await inside arrow functions (#9074) 🚫 Error handling out of scope for Sucrase. 07eaa3c63 Ignore empty fixture directories and fix fixtures in the parser (#9113) 🚫 Test-only. 393283053 Parse non-octals with leading zeros in non strict mode correctly (#9114) 🚫 Sucrase assumes strict mode, so this doesn't apply. fa9df678a Move tests from babylon to babel-parser and enable one test that works now 🚫 Test-only. fdc869ce1 Merge pull request #8289 from valtech-nyc/implement-smart-pipeline-in-parser ✅ Almost all logic was for error-reporting and complexity around node creation, but I did add # as a valid expression. 282129ea6 v7.2.0 🚫 Release only. 4ca35ef8b Fix running flow on travis and update flow (#9128) 🚫 Types only. 72471aff6 Handle flow comments with leading spaces (#9168) 🚫 Sucrase doesn't do anything special for flow comments. c1499b13a v7.2.2 🚫 Release only. 5cb38995c Allow keywords to be used in type annotations (#9184) ✅ I also fixed this for TypeScript. 0bb720401 v7.2.3 🚫 Release only. b5177ce29 babel-parser: typescript: add missing bigint keyword (#9230) 🚫 Test only. 60ffe1d10 parser, smart pipes: Add test for async–await 🚫 Test only. c586d4e8c parser, smart pipes: Add support for yield in pipeline bodies 🚫 Only validation change, startsExpr was removed from Sucrase. a58893d1e Ensure modifiers are included in TSParameterProperty ranges (#9276) 🚫 AST only. e43777bb5 Fix location for typescript type assertions in AST (#9284) 🚫 AST only, wasn't a problem in Sucrase tokens. 03022d169 Throw error if TypeScript class has empty implements (#9292) 🚫 Error handling only. 46e3f6df1 @babel/parser: include leading character into range of generic ArrowFunctionExpression (#9295) 🚫 AST only. 2cc037675 @babel/parser(ts): Add parsing of type import (#9302) 🚫 Already done in #380. 9764718c3 Disallow trailing comma after rest (#9311) 🚫 Error handling only. 5889620a6 Disallow `new import(x)` and `import(x,)` (#9313) 🚫 Error handling only. 3e4b608a8 Parse class heritage as strict mode code (#9315) 🚫 Sucrase is always in strict mode. 694e3fd8c Merge declaration and init of props in parser's state (#9312) 🚫 Refactor that isn't relevant to Sucrase. e8038863c Fix range on TypeScript this type predicate (#9339) 🚫 AST only. 34c9890f4 Fix range on TypeScript index signature parameters (#9335) 🚫 AST only. aaec2cd51 Fix handling newline with TypeScript declare and abstract classes (#9328) ✅ Implemented newline checking in various places. 0a88230ec Disallow async functions as loop bodies (#9314) 🚫 Error handling only. a2e6d8e96 Disallow usage of invalid keyword after export abstract statement in Typescript (#9336) 🚫 Error handling only. 96a734314 Merge pull request #9348 from danez/perf 🚫 Nothing stood out as being valuable to incorporate. f6ee26c3d v7.3.0 🚫 Release only. af88e63df fix new keyword broken by recent refactoring (#9377) 🚫 Not relevant in Sucrase. f2af6c117 v7.3.1 🚫 Release only. f77c450cd Bump prettier (#9373) 🚫 Tooling only. 65febdd13 Refactor import and export parsing (#9326) 🚫 Skipping refactor for now since it's not clear that I'll need it. 93e1b5e61 Merge pull request #9375 from danez/contextual-let 🚫 Not necessary for strict mode. 8bc9f9a05 fix: Allow toplevel await when option true and correctly mark await keyword as unexpected (#9371) 🚫 Error handling only. 42c5d3fc4 Correctly fail for invalid yield in for (#9398) 🚫 Error handling only. 46ba5940c Make yield a contextual keyword (#9400) 🚫 Not necessary for strict mode. 7dc157f9b Fix location/range on TypeScript ExportNamedDeclarations (#9406) 🚫 AST only.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277
There's a decision point on whether the upcoming type is a function type or not,
and it wasn't considering destructured params.