Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't emit await keyword with ES transforms disabled #624

Merged
merged 1 commit into from
Jun 20, 2021

Conversation

alangpierce
Copy link
Owner

Follow-up to #623. With transforms disabled, we should just early return even in
the async case.

Follow-up to #623. With transforms disabled, we should just early return even in
the async case.
@codecov
Copy link

codecov bot commented Jun 20, 2021

Codecov Report

Merging #624 (c643b00) into main (edc56e0) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
+ Coverage   82.18%   82.20%   +0.02%     
==========================================
  Files          56       56              
  Lines        5876     5874       -2     
  Branches     1327     1326       -1     
==========================================
  Hits         4829     4829              
+ Misses        763      762       -1     
+ Partials      284      283       -1     
Impacted Files Coverage Δ
src/TokenProcessor.ts 93.75% <ø> (+1.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc56e0...c643b00. Read the comment docs.

@github-actions
Copy link

Benchmark results

Before this PR: 340.8 thousand lines per second
After this PR: 346 thousand lines per second

Measured change: 1.53% faster (3.64% slower to 6.89% faster)
Summary: Likely no significant difference

@alangpierce alangpierce merged commit 6b6c0d7 into main Jun 20, 2021
@alangpierce alangpierce deleted the skip-await-with-es-transforms-disabled branch June 20, 2021 00:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant