Refactor jsx-test to better support testing the automatic runtime #738
+242
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the automatic runtime effectively doubles the number of cases needing test coverage, plus has a number of cases within itself, this PR refactors the JSX tests to make it easy to declare the result for multiple configurations in the same test. This should make it smoother to write the automatic case for each test where it feels relevant, plus makes it easier to test ESM vs CJS and dev vs prod for the same syntax case.
Codecov Report
@@ Coverage Diff @@
## main #738 +/- ##
=======================================
Coverage 87.17% 87.17%
=======================================
Files 54 54
Lines 5722 5722
Branches 1349 1349
=======================================
Hits 4988 4988
Misses 466 466
Partials 268 268 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark resultsBefore this PR: 330.3 thousand lines per second Measured change: 1.95% slower (3.17% slower to 0.44% faster) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the automatic runtime effectively doubles the number of cases needing test
coverage, plus has a number of cases within itself, this PR refactors the JSX
tests to make it easy to declare the result for multiple configurations in the
same test. This should make it smoother to write the automatic case for each
test where it feels relevant, plus makes it easier to test ESM vs CJS and dev vs
prod for the same syntax case.