Minor refactors in prep for new JSX runtime #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has a few details pulled from #740 to make it easier to read the substantial changes in that PR: * Reorder the options interface to better group related options together. * Reorder the methods in JSXTransformer to be in (roughly) top-down topological order rather than the more scattered order that it was previously. * Change website advanced options to dynamically only show the ones relevant based on what is selected.
Codecov Report
@@ Coverage Diff @@
## main #742 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 54 54
Lines 5751 5751
Branches 1357 1357
=======================================
Hits 5017 5017
Misses 466 466
Partials 268 268
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark resultsBefore this PR: 411 thousand lines per second Measured change: 0.96% faster (0.87% slower to 1.5% faster) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few details pulled from #740 to make it easier to read the
substantial changes in that PR:
order rather than the more scattered order that it was previously.
based on what is selected.