Fix parsing of << within a type #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #758 There was already some logic from #716 to handle cases like `f<<T>() => void>`, where we're transitioning from a non-type context to a type context and need to detect if `<<` is actually two open-type-parameter/argument tokens. There was a simpler missing case, though, which is that `<<` is never allowed within a type, so we should exit early with a simple `<` in a type context. There was already a similar case for `>`, so this just uses the same logic for `<`. This fixes the same issue in TS and Flow.
Codecov Report
@@ Coverage Diff @@
## main #769 +/- ##
==========================================
+ Coverage 87.52% 87.56% +0.03%
==========================================
Files 55 55
Lines 5886 5888 +2
Branches 1394 1395 +1
==========================================
+ Hits 5152 5156 +4
+ Misses 465 464 -1
+ Partials 269 268 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark resultsBefore this PR: 378.8 thousand lines per second Measured change: 0.59% faster (0.31% slower to 1.27% faster) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #758
There was already some logic from #716 to handle cases like
f<<T>() => void>, where we're transitioning from a non-type context to a type context and need to detect if<<is actually two open-type-parameter/argument tokens. There was a simpler missing case, though, which is that<<is never allowed within a type, so we should tokenize as a simple<in atype context. To handle the various cases correctly, this extra logic needs to only happen for
<<, and this PR also addssome additional comments explaining the nuances.