Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix some additional enableLegacyBabel5ModuleInterop cases #807

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

alangpierce
Copy link
Owner

Follow-up from #804.

  • When exporting {T as default}, treat it as a type-only export that doesn't count as a real default export.
  • When explicitly doing export default T, treat it as a type-only export.
  • Treat export enum as a named export.

Follow-up from #804.
* When exporting `{T as default}`, treat it as a type-only export that doesn't
  count as a real default export.
* When explicitly doing `export default T`, treat it as a type-only export.
* Treat `export enum` as a named export.
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #807 (b3f6ea2) into main (631f64c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   88.53%   88.59%   +0.05%     
==========================================
  Files          55       56       +1     
  Lines        6047     6058      +11     
  Branches     1434     1435       +1     
==========================================
+ Hits         5354     5367      +13     
+ Misses        424      423       -1     
+ Partials      269      268       -1     
Impacted Files Coverage Δ
src/transformers/CJSImportTransformer.ts 90.09% <100.00%> (+0.16%) ⬆️
src/transformers/ESMImportTransformer.ts 95.40% <100.00%> (-0.11%) ⬇️
src/util/isExportFrom.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Benchmark results

Before this PR: 347 thousand lines per second
After this PR: 346.6 thousand lines per second

Measured change: 0.11% slower (2.75% slower to 1.01% faster)
Summary: Likely no significant difference

@alangpierce alangpierce merged commit 58eac08 into main Jul 12, 2023
@alangpierce alangpierce deleted the fix-more-add-module-exports-cases branch July 12, 2023 17:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant