-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Blackfy the code #280
Blackfy the code #280
Conversation
9615413
to
4759fce
Compare
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 26 26
Lines 1761 1761
Branches 379 379
=======================================
Hits 1738 1738
Misses 3 3
Partials 20 20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4759fce
to
654e999
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
(I am not 100% on board with all of blacks formatting but I don't want to worry about it... so all fine)
@orbeckst If one doesn't want to blackfy certain regions of code, one could use something similar to 'param: no cover' to allow black to ignore it. |
Yeah, it's ok. I think I am ok with the trade-off between not having to think about formatting ever again and making minor decisions about preferred/marginally more legible indentation etc. It's fine. |
- gitignore _version - ignore commits for blame that contain black-reformatting (in particular we forgot to include #280)
- gitignore _version - ignore commits for blame that contain black-reformatting (in particular we forgot to include #280)
- gitignore _version - ignore commits for blame that contain black-reformatting (in particular we forgot to include #280)
- gitignore _version - ignore commits for blame that contain black-reformatting (in particular we forgot to include alchemistry#280)
Refactor the code according to black and add black check to the ci.