Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Blackfy the code #280

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Blackfy the code #280

merged 3 commits into from
Dec 6, 2022

Conversation

xiki-tempula
Copy link
Collaborator

Refactor the code according to black and add black check to the ci.

@xiki-tempula xiki-tempula force-pushed the feat_black branch 3 times, most recently from 9615413 to 4759fce Compare December 5, 2022 23:14
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #280 (f07fb18) into master (380302d) will not change coverage.
The diff coverage is 99.09%.

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          26       26           
  Lines        1761     1761           
  Branches      379      379           
=======================================
  Hits         1738     1738           
  Misses          3        3           
  Partials       20       20           
Impacted Files Coverage Δ
src/alchemlyb/postprocessors/__init__.py 100.00% <ø> (ø)
src/alchemlyb/workflows/__init__.py 100.00% <ø> (ø)
src/alchemlyb/visualisation/dF_state.py 95.83% <92.30%> (ø)
src/alchemlyb/parsing/gomc.py 93.33% <95.65%> (ø)
src/alchemlyb/workflows/abfe.py 99.66% <99.22%> (ø)
src/alchemlyb/__init__.py 100.00% <100.00%> (ø)
src/alchemlyb/convergence/convergence.py 100.00% <100.00%> (ø)
src/alchemlyb/estimators/__init__.py 100.00% <100.00%> (ø)
src/alchemlyb/estimators/bar_.py 100.00% <100.00%> (ø)
src/alchemlyb/estimators/base.py 100.00% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

(I am not 100% on board with all of blacks formatting but I don't want to worry about it... so all fine)

@orbeckst orbeckst merged commit 0095be2 into alchemistry:master Dec 6, 2022
@orbeckst orbeckst mentioned this pull request Dec 6, 2022
@xiki-tempula xiki-tempula deleted the feat_black branch December 6, 2022 20:52
@xiki-tempula
Copy link
Collaborator Author

@orbeckst If one doesn't want to blackfy certain regions of code, one could use something similar to 'param: no cover' to allow black to ignore it.

@orbeckst
Copy link
Member

orbeckst commented Dec 6, 2022

Yeah, it's ok. I think I am ok with the trade-off between not having to think about formatting ever again and making minor decisions about preferred/marginally more legible indentation etc. It's fine.

orbeckst added a commit that referenced this pull request Sep 17, 2024
- gitignore _version
- ignore commits for blame that contain black-reformatting
  (in particular we forgot to include #280)
orbeckst added a commit that referenced this pull request Sep 17, 2024
- gitignore _version
- ignore commits for blame that contain black-reformatting
  (in particular we forgot to include #280)
orbeckst added a commit that referenced this pull request Sep 17, 2024
- gitignore _version
- ignore commits for blame that contain black-reformatting
  (in particular we forgot to include #280)
jaclark5 pushed a commit to jaclark5/alchemlyb that referenced this pull request Sep 19, 2024
- gitignore _version
- ignore commits for blame that contain black-reformatting
  (in particular we forgot to include alchemistry#280)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants