-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: bump eslint v9 #54
Conversation
"@typescript-eslint/eslint-plugin": "^8.13.0", | ||
"@typescript-eslint/parser": "^8.13.0", | ||
"clsx": "^2.1.0", | ||
"eslint-plugin-react": "^7.37.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are still dev dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does that mean?
const GLOBALS_BROWSER_FIX = Object.assign({}, globals.browser, { | ||
AudioWorkletGlobalScope: globals.browser["AudioWorkletGlobalScope "], | ||
}); | ||
delete GLOBALS_BROWSER_FIX["AudioWorkletGlobalScope "]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there was an issue and warnings when i tried to bump eslint v9
and found this link sindresorhus/globals#239
@@ -0,0 +1,64 @@ | |||
import { fixupConfigRules } from "@eslint/compat"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need compat
or FlatCompat
anymore, as all the plugins/configs that we are using are now compatible with v9. Can you check again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting errors so i followed this
https://eslint.org/blog/2024/05/eslint-compatibility-utilities/
I am really not to sure what I was doing here and how to work on this issue |
As this PR is stale, I will close it. Please feel free to reopen it once ready 🙏 |
bump eslint v9
node v22
please review eslint v9 - it had a dep issues with @typescript-eslint/parser