Skip to content

Use 1.14.4 as bundled HDF5 #243

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Use 1.14.4 as bundled HDF5 #243

wants to merge 10 commits into from

Conversation

mulimoen
Copy link
Collaborator

@mulimoen mulimoen commented Jun 9, 2023 •
edited by aldanor
Loading

Replaces #207

Blocked by HDFGroup/hdf5#3091

@mulimoen
Copy link
Collaborator Author

mulimoen commented Jun 9, 2023

Hitting some bug in hdf5. Need to find a windows machine to find a fix and upstream this

@aldanor
Copy link
Owner

aldanor commented Jun 9, 2023

Wonder if we could git-bisect it in a sane way...

@mulimoen
Copy link
Collaborator Author

mulimoen commented Jun 9, 2023

From man off_t

off_t is used for describing file sizes. It is a signed integer type.

Poorly defined in other words. There is a feature test macro we could set, _FILE_OFFSET_BITS, but I am not sure if this will affect other libraries

@mulimoen mulimoen mentioned this pull request Jun 9, 2023
Open
@mulimoen mulimoen force-pushed the feature/static-hdf5-1.14.1 branch from 68c5991 to 139027b Compare June 10, 2023 22:39
@mulimoen mulimoen force-pushed the feature/static-hdf5-1.14.1 branch from d0606a4 to b5494a6 Compare September 7, 2023 18:45
@mulimoen mulimoen changed the title Use 1.14.1 as bundled HDF5 Use 1.14.2 as bundled HDF5 Sep 7, 2023
@mulimoen mulimoen mentioned this pull request Sep 7, 2023
Open
@mulimoen mulimoen force-pushed the feature/static-hdf5-1.14.1 branch from 905030b to 975b18f Compare September 7, 2023 20:33
@mulimoen mulimoen force-pushed the feature/static-hdf5-1.14.1 branch from 6f9fa95 to cc340d8 Compare September 19, 2023 19:26
@gauteh gauteh mentioned this pull request Sep 28, 2023
Closed
@gauteh
Copy link

gauteh commented Sep 29, 2023

Would this PR give us a version with chunks_visit?

@mulimoen
Copy link
Collaborator Author

@gauteh Yes, this would provide chunks_visit.

@gauteh
Copy link

gauteh commented Sep 29, 2023

Great! Looking forward to this!

@mulimoen mulimoen force-pushed the feature/static-hdf5-1.14.1 branch from e8b4b32 to c49f0fd Compare November 5, 2023 11:22
@mulimoen mulimoen changed the title Use 1.14.2 as bundled HDF5 Use 1.14.3 as bundled HDF5 Nov 5, 2023
@mulimoen mulimoen force-pushed the feature/static-hdf5-1.14.1 branch 3 times, most recently from 7aad547 to 62d3637 Compare November 5, 2023 12:21
@mulimoen
Copy link
Collaborator Author

mulimoen commented Nov 5, 2023

Still some mysterious errors here. On wine StrStrIA from shlwapi is not found (maybe this library has a different name on wine compared to windows?). mingw and mingw-static fails with STATUS_STACK_BUFFER_OVERRUN / STATUS_HEAP_CORRUPTION, although this seems to be the case in the current CI too.

@mulimoen mulimoen force-pushed the feature/static-hdf5-1.14.1 branch from 62d3637 to 503dcbf Compare February 6, 2024 20:12
@mulimoen mulimoen force-pushed the feature/static-hdf5-1.14.1 branch from f51bc0a to 1573f34 Compare March 28, 2024 14:32
jedbrown
jedbrown reviewed May 9, 2024
View reviewed changes
hdf5-sys/build.rs
@@ -29,7 +29,7 @@ impl Version {
}

pub fn parse(s: &str) -> Option<Self> {
let re = Regex::new(r"^(1)\.(8|10|12|14)\.(\d\d?)(_\d+)?((-|.)(patch)?\d+)?$").ok()?;
let re = Regex::new(r"^(1)\.(8|10|12|14)\.(\d\d?)(_|.\d+)?((-|.)(patch)?\d+)?$").ok()?;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the . intended to be escaped \.? If not, the regex can be shortened. In any case, I now see version strings "1.14.4-2".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably simplify it greatly by ignoring everything after number.number.number

@mulimoen mulimoen changed the title Use 1.14.3 as bundled HDF5 Use 1.14.4 as bundled HDF5 May 12, 2024
@JamesMc86 JamesMc86 mentioned this pull request May 23, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jedbrown jedbrown jedbrown left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mulimoen @aldanor @gauteh @jedbrown