Only calculate hash once for Marker objects #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
commented
Jun 8, 2024
alecthomas
approved these changes
Jun 8, 2024
voluptuous/schema_builder.py
Outdated
| description: typing.Optional[str] = None, | ||
| ) -> None: | ||
| super().__init__(schema_, msg, description) | ||
| self.__hash__ = lru_cache(maxsize=None)(lambda: object.__hash__(self)) |
There was a problem hiding this comment.
Why is this necessary? Doesn't Marker.__hash__ cover this?
There was a problem hiding this comment.
Its overriding the hash here to use the base object.__hash__ instead of Marker.__hash__
alecthomas
reviewed
Jun 8, 2024
|
I'm letting this run over the weekend on my production Home Assistant so I can examine the cache on Monday once its run for a bit. If all still looks well, I'll mark it ready for review than |
|
@bdraco Out of curiosity a side-question: What did you do/use to make those graphs? |
|
They are made using cProfile and than it's converted to a callgrind file and opened in qcachegrind More details at https://www.home-assistant.io/integrations/profiler/ |
|
Thanks. Looking forward to this one in a production HA |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after
