Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEATURE] - remove additional files (from git submodules) while packaging the extension #355

Closed
KevinBuchs opened this issue Nov 20, 2020 · 4 comments
Labels
depends on Depends on issues from VS Code enhancement internal

Comments

@KevinBuchs
Copy link

  • Extension version: 11.4.0
  • VSCode version: 1.51.1
  • OS version: Ubuntu 20.04

Steps to reproduce

  1. Install extension
  2. Find in the extension directory ~/.vscode/extensions/alefragnani.bookmarks-11.4.0 these subdirectories: vscode-bookmarks-core and vscode-whats-new. Each of these contain files named ".git". In the first one, that is all that is in the directory.
  3. These files are messing up my application that backs up git working directories, because these look like they might be. I can't imagine what use these files are.
@KevinBuchs KevinBuchs added the bug label Nov 20, 2020
@alefragnani
Copy link
Owner

Hi @KevinBuchs ,

These .git files appears to be from the git submodules that the extension uses. It appears the tool used to build/package extensions (vsce) doesn’t support git submodules.

I’ll take a look if this could be added to the tool, or if the extension itself must ignore those files.

Thanks for reporting

@alefragnani alefragnani changed the title [BUG] - some trash in the installation - .git files [FEATURE] - remove additional files (from git submodules) while packaging the extension Nov 25, 2020
@alefragnani alefragnani added enhancement internal depends on Depends on issues from VS Code and removed bug labels Nov 25, 2020
@alefragnani
Copy link
Owner

The VS Code team already updated vsce to ignore git submodule related files. It will be available in upcoming November release.

Update the extension after that

@alefragnani alefragnani added this to the December 2020 milestone Nov 27, 2020
@KevinBuchs
Copy link
Author

KevinBuchs commented Nov 30, 2020 via email

@alefragnani
Copy link
Owner

Tested with vice 1.83 and it works.

Closing as there is nothing to do. The next publishing will work as expected

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
depends on Depends on issues from VS Code enhancement internal
Projects
None yet
Development

No branches or pull requests

2 participants