Wallet Extension Integration #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
h0ngcha0
commented
Sep 6, 2022
h0ngcha0
commented
- Picked Muchen's work for extension wallet integration
- Fixed some UI issues by updating the extension wallet
h0ngcha0
commented
Sep 6, 2022
|
The test failed because of this: bufbuild/buf#1380, we need to update the |
Thanks for the fix! <3 |
h0ngcha0
force-pushed
the
integrate-with-wallet-extension-hc
branch
from
06209d0 to
d076daa
Compare
h0ngcha0
changed the base branch from
add-alephium-to-wormhole
to
fix-buf-build
polarker
approved these changes
Sep 9, 2022
| return undefined | ||
| const tokenAddress = toAlphContractAddress(tokenId) | ||
| try { | ||
| const group = await provider.addresses.getAddressesAddressGroup(tokenAddress) |
There was a problem hiding this comment.
There should be an utility function for this in web3.
| } catch (error) { | ||
| console.log("failed to get alephium token info, error: " + error) | ||
| return undefined | ||
| } |
There was a problem hiding this comment.
This function is for testing purpose only right?
later we will read such information from a public repo token-list.
There was a problem hiding this comment.
Yes, it's only for testing now, wormhole also has a repo for this: https://github.com/certusone/wormhole-networks.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.