v0.8.24 healthier piggos & bugfixes #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
alexanderclarktx
commented
Oct 18, 2024
•
alexanderclarktx
commented
- improved piggo size/collider/eat scaling as he grows
- fixed shaky movement bug
| } | ||
|
|
||
| if (entity.components.collider) { | ||
| // @ts-expect-error | ||
| entity.components.collider.colliderDesc.shape.radius *= 1.1 | ||
| entity.components.collider.colliderDesc.shape.radius += 1 |
There was a problem hiding this comment.
better piggo collider scaling as he grows
| @@ -147,6 +147,8 @@ export const PositionSystem: SystemBuilder<"PositionSystem"> = { | |||
| velocity: { ...velocity }, | |||
| pointingDelta: { ...pointingDelta }, | |||
| } | |||
|
|
|||
| position.lastCollided = following.components.position.lastCollided | |||
There was a problem hiding this comment.
lastCollided copied to follower
| @@ -61,7 +61,7 @@ const npcOnTick = (entity: Entity<Position>, world: World): void | InvokedAction | |||
| const closest = closestEntity(edibles, position.data, 200) | |||
|
|
|||
| if (closest) { | |||
| if (XYdelta(position.data, closest.components.position.data) < 20) { | |||
| if (XYdelta(position.data, closest.components.position.data) < 20 + (0.5 * renderable!.scale * renderable!.scale)) { | |||
There was a problem hiding this comment.
scaling Eat distance with renderable scale
| @@ -16,7 +16,7 @@ export const IsometricWorld: WorldBuilder = (props) => { | |||
| world.addSystemBuilders([ | |||
| ExpiresSystem, ControlSystem, ClickableSystem, InputSystem, DebugSystem, | |||
| DamageSystem, CommandSystem, NPCSystem, NametagSystem, CooldownSystem, | |||
| ActionSystem, EffectsSystem, PhysicsSystem, PositionSystem, RenderSystem | |||
| PhysicsSystem, ActionSystem, EffectsSystem, PositionSystem, RenderSystem | |||
There was a problem hiding this comment.
previous ordering was causing velocity to be reset -> player movement was not interpolated (shaky)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.