Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Batch normalization #21

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Conversation

bato3
Copy link
Contributor

@bato3 bato3 commented Oct 19, 2021

Big optimization, includes:

  • Endpoint renaming - because the entire URL obscures the view and the actual URL is in a different part of the schema (remove {{base_path}}/api/index.php/v1/ from item.name)
    image
  • Rename variable {{base_path}} to {{base_url}}, because I need this name for next variable :)
  • Set api/index.php/v1 as variable - because in NGINX it's easier to run SEF than classic links. (I can use only api/v1/, default don't work)
  • Set api key as variable {{auth_apikey}} - that's a recommendation from Postman
  • Discover variables in URL-s e.g. {{article_id}}
  • Normalize URLs to: {{base_path}}/{{base_url}}/important-part-of-the-url, and all variables are double moustached
  • Normalize JSON body, because all fields should be double-quoted, (discussion in escape single qote in "Here's an article" #18)
  • Fix descriptions, because body was reformatted and alexandreelise don't allow remove it (Purposefulness of the description field.  #20)

@alexandreelise
Copy link
Owner

Hi @bato3 Your pull request has been merge in a new branch dedicated to your improvements. If you would will to enhance more please pull request against that branch rather than master. Thanks for your contribution. Have a great day.

@alexandreelise alexandreelise merged commit 6358098 into alexandreelise:master Dec 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants