Codebase upgrade #112
Codebase upgrade #112
Conversation
|
|
||
| extern crate futures_await as futures; | ||
| extern crate tokio_core; | ||
| extern crate tokio_io; | ||
|
|
||
| use std::io::{self, BufReader}; | ||
|
|
||
| use futures::prelude::*; | ||
| use futures::prelude::{r#await, *}; |
There was a problem hiding this comment.
If you activate the await_macro feature await will not be a keyword (at least at the moment).
There was a problem hiding this comment.
I think adapting to "standard" language syntax rather than bringing in more features is the better way forward.
|
I'm about to go on vacation for the rest of the week and then the next week is a Rust all hands, so I'm not sure when I'll be able to pay this proper attention. A question for you to think about in the meantime: would you be interested in maintaining this crate? |
|
@withoutboats Yes, I would. |
|
@withoutboats Could you please take a stab at reviewing this PR? futures-await has been unusable on the latest nightly for quite some time now. |
|
This would have been great to have. |
|
At this point it looks like there is no one able to review this PR. Therefore I urge all those who depend on latest nightlies to move to mainline async/await and gen-stream crate. |
This PR upgrades the code to latest Rust nightly.
stream_yieldmacro.