Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add order free shipping #47

Merged
merged 3 commits into from
Mar 8, 2025
Merged

Conversation

tubaman
Copy link
Contributor

@tubaman tubaman commented Mar 7, 2025

Description

Add the ability to handle the "Free Shipping" field

image

Fixes # (issue number)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a schema change
  • This change requires a documentation update

Testing Done

Added test and ran make test

Checklist

  • I have added tests that prove my change works as expected, and make test passes with no new errors or warnings
  • I have run make check to ensure no new errors or warnings
  • I have updated the docs, if applicable, and run make docs to ensure no new errors or warnings
  • I have performed a self-review of my own code
  • I have commented my code in particularly hard-to-understand areas

@alexdlaird alexdlaird marked this pull request as ready for review March 8, 2025 15:24
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.77%. Comparing base (a95aca4) to head (81b3b0c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
amazonorders/cli.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   89.83%   89.77%   -0.07%     
==========================================
  Files          18       18              
  Lines        1092     1095       +3     
==========================================
+ Hits          981      983       +2     
- Misses        111      112       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexdlaird alexdlaird merged commit 36d1662 into alexdlaird:main Mar 8, 2025
11 of 13 checks passed
@alexdlaird
Copy link
Owner

Released in 3.2.14. Thanks for the contribution!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants