Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support of cloud-hypervisor and ch-remote binary #1018

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

nitishkumar71
Copy link
Contributor

@nitishkumar71 nitishkumar71 commented Jan 14, 2024

Description

  1. Add support for cloud-hypervisor binary and ch-remote client binary to work with VMM
  2. Existing kube-burner download was broken as per their past few latest releases.

Motivation and Context

How Has This Been Tested?

If updating or adding a new CLI to arkade get, run:

go build && ./hack/test-tool.sh TOOL_NAME
  1. Run go build && ./hack/test-tool.sh ch-remote produces below output
+ ./arkade get ch-remote --arch arm64 --os darwin --quiet
+ file /home/nitishkumar/.arkade/bin/ch-remote
/home/nitishkumar/.arkade/bin/ch-remote: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, BuildID[sha1]=b9899369fb13f74ea35208d6d4053763f7ec87aa, stripped
+ rm /home/nitishkumar/.arkade/bin/ch-remote
+ echo

+ ./arkade get ch-remote --arch x86_64 --os darwin --quiet
+ file /home/nitishkumar/.arkade/bin/ch-remote
/home/nitishkumar/.arkade/bin/ch-remote: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, BuildID[sha1]=b9899369fb13f74ea35208d6d4053763f7ec87aa, stripped
+ rm /home/nitishkumar/.arkade/bin/ch-remote
+ echo

+ ./arkade get ch-remote --arch x86_64 --os linux --quiet
+ file /home/nitishkumar/.arkade/bin/ch-remote
/home/nitishkumar/.arkade/bin/ch-remote: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, BuildID[sha1]=b9899369fb13f74ea35208d6d4053763f7ec87aa, stripped
+ rm /home/nitishkumar/.arkade/bin/ch-remote
+ echo

+ ./arkade get ch-remote --arch aarch64 --os linux --quiet
+ file /home/nitishkumar/.arkade/bin/ch-remote
/home/nitishkumar/.arkade/bin/ch-remote: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, stripped
+ rm /home/nitishkumar/.arkade/bin/ch-remote
+ echo

+ ./arkade get ch-remote --arch x86_64 --os mingw --quiet
+ file /home/nitishkumar/.arkade/bin/ch-remote.exe
/home/nitishkumar/.arkade/bin/ch-remote.exe: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, BuildID[sha1]=b9899369fb13f74ea35208d6d4053763f7ec87aa, stripped
+ rm /home/nitishkumar/.arkade/bin/ch-remote.exe
+ echo
    1. Run go build && ./hack/test-tool.sh cloud-hypervisor produces below output
+ ./arkade get cloud-hypervisor --arch arm64 --os darwin --quiet
+ file /home/nitishkumar/.arkade/bin/cloud-hypervisor
/home/nitishkumar/.arkade/bin/cloud-hypervisor: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, BuildID[sha1]=ead37764790ed54e3bdc6db0e7ccc1615df4ca08, stripped
+ rm /home/nitishkumar/.arkade/bin/cloud-hypervisor
+ echo

+ ./arkade get cloud-hypervisor --arch x86_64 --os darwin --quiet
+ file /home/nitishkumar/.arkade/bin/cloud-hypervisor
/home/nitishkumar/.arkade/bin/cloud-hypervisor: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, BuildID[sha1]=ead37764790ed54e3bdc6db0e7ccc1615df4ca08, stripped
+ rm /home/nitishkumar/.arkade/bin/cloud-hypervisor
+ echo

+ ./arkade get cloud-hypervisor --arch x86_64 --os linux --quiet
+ file /home/nitishkumar/.arkade/bin/cloud-hypervisor
/home/nitishkumar/.arkade/bin/cloud-hypervisor: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, BuildID[sha1]=ead37764790ed54e3bdc6db0e7ccc1615df4ca08, stripped
+ rm /home/nitishkumar/.arkade/bin/cloud-hypervisor
+ echo

+ ./arkade get cloud-hypervisor --arch aarch64 --os linux --quiet
+ file /home/nitishkumar/.arkade/bin/cloud-hypervisor
/home/nitishkumar/.arkade/bin/cloud-hypervisor: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, stripped
+ rm /home/nitishkumar/.arkade/bin/cloud-hypervisor
+ echo

+ ./arkade get cloud-hypervisor --arch x86_64 --os mingw --quiet
+ file /home/nitishkumar/.arkade/bin/cloud-hypervisor.exe
/home/nitishkumar/.arkade/bin/cloud-hypervisor.exe: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, BuildID[sha1]=ead37764790ed54e3bdc6db0e7ccc1615df4ca08, stripped
+ rm /home/nitishkumar/.arkade/bin/cloud-hypervisor.exe
+ echo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
@nitishkumar71 nitishkumar71 force-pushed the support_cloud_hypervisor branch from 6b6cbdf to a9ea204 Compare January 14, 2024 16:10
Copy link
Contributor

@Shikachuu Shikachuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, thanks for the kube-burner fix btw! 👍

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 67314ef into alexellis:master Jan 24, 2024
2 checks passed
@nitishkumar71 nitishkumar71 deleted the support_cloud_hypervisor branch March 16, 2024 13:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cloud-hypervisor and cloud-hypervisor-remote as downloads
3 participants