Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix croc file pattern & e2e test #1031

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix croc file pattern & e2e test #1031

merged 1 commit into from
Feb 16, 2024

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Feb 16, 2024

Description

croc changed its assets pattern at v9.6.7 from 9.6.6 to v9.6.7 this caused the url checker tests to fail.
This change updates the asset pattern and bumps all references to v9.6.10.
Also removes log.txt from the top level of the repo as this appears to have been committed erroneously.

Motivation and Context

Alex pinged for assistance via discord

How Has This Been Tested?

Given the nature of the issue this was tested using a GH action workflow

image

If updating or adding a new CLI to arkade get, run:

go build && ./hack/test-tool.sh TOOL_NAME

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Richard Gee <richard@technologee.co.uk>
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 2f45088 into alexellis:master Feb 16, 2024
2 checks passed
@alexellis
Copy link
Owner

Thank you for this

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants