Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add hold file for chart upgrade #1135

Closed
wants to merge 2 commits into from
Closed

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Nov 9, 2024

Description

Adds a feature to the chart upgrade command such that images within the target file can be ignored during the upgrade if they are detailed in a hold file. To be considered the file should follow the name of the yaml file passed by -f suffixed with .hold, e.g. upgrading docker-compose.yaml would look for a docker-compose.yaml.hold.

The hold file format is:

component1.image
db.image
...
nats.image

Motivation and Context

How Has This Been Tested?

TBC

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

if len(filtered) > 0 {
log.Printf("Found %d images\n", len(filtered))
}
log.Printf("Found %d images\n", len(filtered))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filtered will be non-zero as we return earlier if len==0

Signed-off-by: Richard Gee <richard@technologee.co.uk>
Signed-off-by: Richard Gee <richard@technologee.co.uk>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading container image tags - hold feature
1 participant