Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add way to hold/ignore images when upgrading compose/charts #1149

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

alexellis
Copy link
Owner

@alexellis alexellis commented Jan 30, 2025

Description

Add way to hold/ignore images when upgrading compose/charts

Motivation and Context

When upgrading image versions in a compose file or helm chart there are cases where certain components like a database version should be static and not change.

This change introduces a more generic concept than previously planned of an arkade config file. The ignore section includes paths to images which should be ignored and filtered out prior to looking up new images.

How Has This Been Tested?

Tested with the OpenFaaS pro-builder chart, with the path buildkit.image, I was able to ignore only that image whilst having the other images inspected/updated.

image

go run . chart upgrade -f ~/go/src/github.com/openfaas/faas-netes/chart/pro-builder/values.yaml  --verbose
2025/01/30 11:38:21 Verifying images in: /home/alex/go/src/github.com/openfaas/faas-netes/chart/pro-builder/values.yaml
2025/01/30 11:38:21 Found 2 images
2025/01/30 11:38:22 [moby/buildkit] v0.15.1-rootless => v0.19.0-rootless

Then arkade.yaml was placed next to values.yaml:

ignore:
  - buildkit.image

Buildkit was ignored:

go run . chart upgrade -f ~/go/src/github.com/openfaas/faas-netes/chart/pro-builder/values.yaml  --verbose
2025/01/30 11:39:04 Verifying images in: /home/alex/go/src/github.com/openfaas/faas-netes/chart/pro-builder/values.yaml
2025/01/30 11:39:04 Found 1 images

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

The documentation has been updated in the cobra command and within the examples.

When upgrading image versions in a compose file or helm chart
there are cases where certain components like a database version
should be static and not change.

This change introduces a more generic concept than previously
planned of an arkade config file. The ignore section includes
paths to images which should be ignored and filtered out
prior to looking up new images.

Tested with the OpenFaaS pro-builder chart, with the path
buildkit.image, I was able to ignore only that image whilst
having the other images inspected/updated.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis force-pushed the config-file-hold-images branch from 657d353 to 8a995e3 Compare January 30, 2025 11:39
@alexellis alexellis merged commit fa9f92f into master Jan 30, 2025
4 checks passed
@alexellis alexellis deleted the config-file-hold-images branch January 30, 2025 11:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant