Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add dotenv-linter tool to arkade get #1152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joebowbeer
Copy link
Contributor

@joebowbeer joebowbeer commented Feb 14, 2025

Description

Add dotenv-linter tool for linting .env files.

Motivation and Context

Fixes #1151

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

  • Ran ./arkade get dotenv-linter on macos M1 and verified that the tool worked.
  • go build && make test && make e2e

If updating or adding a new CLI to arkade get, run:

go build && ./hack/test-tool.sh TOOL_NAME
+ ./arkade get dotenv-linter --arch arm64 --os darwin --quiet
+ file /Users/me/.arkade/bin/dotenv-linter
/Users/me/.arkade/bin/dotenv-linter: Mach-O 64-bit executable arm64
+ rm /Users/me/.arkade/bin/dotenv-linter
+ echo

+ ./arkade get dotenv-linter --arch x86_64 --os darwin --quiet
+ file /Users/me/.arkade/bin/dotenv-linter
/Users/me/.arkade/bin/dotenv-linter: Mach-O 64-bit executable x86_64
+ rm /Users/me/.arkade/bin/dotenv-linter
+ echo

+ ./arkade get dotenv-linter --arch x86_64 --os linux --quiet
+ file /Users/me/.arkade/bin/dotenv-linter
/Users/me/.arkade/bin/dotenv-linter: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=851f0d948bebc4fdb4197d5f333417d198dfd68b, for GNU/Linux 3.2.0, with debug_info, not stripped
+ rm /Users/me/.arkade/bin/dotenv-linter
+ echo

+ ./arkade get dotenv-linter --arch aarch64 --os linux --quiet
+ file /Users/me/.arkade/bin/dotenv-linter
/Users/me/.arkade/bin/dotenv-linter: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, BuildID[sha1]=332088bc4d25cb774af2a3feb23263af00018fa4, for GNU/Linux 3.7.0, with debug_info, not stripped
+ rm /Users/me/.arkade/bin/dotenv-linter
+ echo

+ ./arkade get dotenv-linter --arch x86_64 --os mingw --quiet
+ file /Users/me/.arkade/bin/dotenv-linter.exe
/Users/me/.arkade/bin/dotenv-linter.exe: PE32+ executable (console) x86-64, for MS Windows
+ rm /Users/me/.arkade/bin/dotenv-linter.exe
+ echo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
@rgee0
Copy link
Contributor

rgee0 commented Feb 14, 2025

Whilst it looks good from a code/approach standpoint it would be good if any existing tool addition PRs were merged prior to this so that earlier contributors aren't left with any rebasing

@joebowbeer
Copy link
Contributor Author

Whilst it looks good from a code/approach standpoint it would be good if any existing tool addition PRs were merged prior to this so that earlier contributors aren't left with any rebasing

What conflicts are you anticipating? The README?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dotenv-linter
2 participants