Added HDMI Source Selection #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added HDMI Source Selection
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| elif source == "Hdmi 2": | ||
| self.sonydevice.input_hdmi2() | ||
| else: | ||
| return "" |
There was a problem hiding this comment.
indentation is not a multiple of four
| def volume_up(self): | ||
| """Send stop command.""" | ||
| self.sonydevice.volume_up() | ||
|
|
||
| def volume_down(self): | ||
| """Send stop command.""" | ||
| self.sonydevice.volume_down() | ||
|
|
| def mute_volume(self, mute): | ||
| """Send stop command.""" | ||
| self.sonydevice.mute() | ||
|
|
| @@ -293,15 +297,30 @@ def media_previous_track(self): | |||
| def media_stop(self): | |||
| """Send stop command.""" | |||
| self.sonydevice.stop() | |||
|
|
|||
|
|
|||
| self.sonydevice = sony_device | ||
| self._state = STATE_OFF | ||
| self._muted = False | ||
| self._id = None | ||
| self._playing = False | ||
| _LOGGER.error(sony_device.pin) | ||
| _LOGGER.error(sony_device.client_id) | ||
|
|
| SUPPORT_PLAY | SUPPORT_PLAY_MEDIA | SUPPORT_STOP | \ | ||
| SUPPORT_VOLUME_MUTE | SUPPORT_VOLUME_STEP | ||
| SUPPORT_SONY = (SUPPORT_PAUSE | ||
| | SUPPORT_PREVIOUS_TRACK |
There was a problem hiding this comment.
continuation line over-indented for visual indent
| SUPPORT_TURN_ON | SUPPORT_TURN_OFF | \ | ||
| SUPPORT_PLAY | SUPPORT_PLAY_MEDIA | SUPPORT_STOP | \ | ||
| SUPPORT_VOLUME_MUTE | SUPPORT_VOLUME_STEP | ||
| SUPPORT_SONY = (SUPPORT_PAUSE |
| SUPPORT_SELECT_SOURCE, | ||
| SUPPORT_VOLUME_MUTE, | ||
| SUPPORT_VOLUME_STEP) | ||
|
|
|
|
||
| SUPPORT_NEXT_TRACK, | ||
| SUPPORT_PAUSE, | ||
| SUPPORT_PREVIOUS_TRACK, |
| import voluptuous as vol | ||
|
|
||
| from homeassistant.components.media_player import ( | ||
| MediaPlayerEntity, PLATFORM_SCHEMA) | ||
|
|
||
|
With your changes a direct merge won't be possible, but I'll take what I need to implement the feature set. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many changes here, mainly because some of the updates you made were not working for me, mainly the registration process, then I rolled back few versions (the one was working fine for me) then added the HDMI selection.
Mainly the last part is related to the HMDI source, as you know, just hardcoded the sources. Just take what you think is good.