Merge upstream from dilruacs repo #37
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use of external file
Added remote entity
# Conflicts: # README.md # custom_components/sony/manifest.json # custom_components/sony/media_player.py # test_config/create_docker.sh
# Conflicts: # custom_components/sony/media_player.py
|
There are a lot of cool changes in here. If you can get this into a working state, it might be worth the effort to get this integrated into HACS |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
Improve volume supprt * Add volume level * Change volume debug level * Add volume set support & normalize volume (cherry picked from commit 4142b1f)
alexmohr
reviewed
Apr 8, 2024
| "documentation": "https://github.com/alexmohr/media_player.sony", | ||
| "dependencies": [], | ||
| "codeowners": [], | ||
| "version": "0.1.1", | ||
| "requirements": ["sonyapilib==0.5.0"] | ||
| "requirements": ["sonyapilib==0.5.0"], |
There was a problem hiding this comment.
With the current master, volume functions are broken because we require 0.5.0 which does not include the new functions yet.
Before accepting this, a new version in sonyapilib has to be released. This comment is as reminder to do that.
There was a problem hiding this comment.
Wouldn't be better to release the new version of sonyapilib now to fix currently broken master?
There was a problem hiding this comment.
Would be better but I don't have time to do so at the moment, so it stays broken until then.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be working, but needs more testing and I have found some bugs which will try to fix later.
Just concept for now :D