fix fetching binary files such as images #504
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, when I fetch binary files such as images create by code_interpreter, I get a parsing error.
I determined that this is because response.is_a?(String) returns true for binary files such as png.
This PR fixes the parsing error, but I suspect there may be a better way to fix it.
For example, if someone was using non-utf-8 string encoding, this could break.
May need more investigation?
All Submissions: