Add tini as entrypoint in Dockerfile #570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the docker container was slow to shut down, just a little over 10 seconds. This is a strong indication that the sigint signal is not getting forwarded to subprocesses properly, and the container only shuts down once it receives sigkill. This is easily fixed by using
tini
as the entrypoint, which will, among other things, handle the signals properly.Here is an example before and after adding
tini
: